From 8e17ff24a0c2dc96337a8ddec7a95e319f1e47df Mon Sep 17 00:00:00 2001 From: Duyi-Wang Date: Thu, 23 Oct 2025 09:32:22 +0800 Subject: [PATCH] fix: walk around acc issue in eager mode for rope forward_hip (#19) Signed-off-by: Duyi-Wang --- vllm/model_executor/layers/rotary_embedding/base.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vllm/model_executor/layers/rotary_embedding/base.py b/vllm/model_executor/layers/rotary_embedding/base.py index 17cd39bb8cd6..2c0f4dd13080 100644 --- a/vllm/model_executor/layers/rotary_embedding/base.py +++ b/vllm/model_executor/layers/rotary_embedding/base.py @@ -168,7 +168,8 @@ def forward_hip( else: # ops.rotary_embedding() is an in-place operation # that updates the query and key tensors. - self.forward_cuda(positions, query, key) + # FIXME: self.forward_cuda is not a in-place operation in eager mode. + return self.forward_cuda(positions, query, key) return query, key def forward_xpu(