-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[Bugfix] Fix broken Minimax-01-VL model #22116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a bug fix for the Minimax-01-VL model and adds a corresponding example for offline inference. The fix correctly handles batched image inputs by applying a nested flatten_bn call, which is crucial for preventing crashes with multiple images. The accompanying docstring update accurately reflects the change in tensor shape. The new example in vision_language.py is well-implemented and follows the existing structure for adding new models. The changes are correct and improve the model's stability.
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Duncan Moss <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Test Plan
Test Result
(Optional) Documentation Update