Skip to content

Conversation

@ruisearch42
Copy link
Collaborator

@ruisearch42 ruisearch42 commented Jul 26, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Currently, ray-based PP uses a cupy/nccl communicator created separately from other communicators in vLLM. This caused inconsistencies and potential conflicts.

This PR introduces RayPPCommunicator, which wraps around vLLM _PP communicator so that the same underlying communicator is used.

This is the major change needed for #19758
and an alternative to #19816

Test Plan

Test with test_pipeline_parallel.py

Test Result

Passed

(Optional) Documentation Update

Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces RayPPCommunicator to integrate vLLM's pipeline parallelism with Ray's Compiled DAG by wrapping the existing vLLM _PP communicator. The changes are logical and well-structured. My review focuses on the new ray_communicator.py file, where I've identified a couple of high-severity maintainability issues: a copy-paste error in error messages and the use of a private Ray API attribute which could be brittle. Addressing these will improve the quality of this new component.

Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42
Copy link
Collaborator Author

@stephanie-wang @youkaichao Could you please help review, thanks

lambda: bool(int(os.getenv("VLLM_USE_RAY_COMPILED_DAG_OVERLAP_COMM", "0"))
),

# If the env var is set, it uses a Ray Communicator wrapping
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this flag? Can we just always use vLLM's PP communicator?

Copy link
Collaborator Author

@ruisearch42 ruisearch42 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in this PR is by default on. Wanted to have this config guard for a while so that users can fall back if needed.
This will be cleaned up altogether after it is rolled out for a while.

Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42 ruisearch42 added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 29, 2025
@ruisearch42
Copy link
Collaborator Author

ruisearch42 commented Jul 30, 2025

Hi @stephanie-wang , I've addressed your comments and full CI passed. Could you take another look?

@carmark
Copy link

carmark commented Jul 30, 2025

@ruisearch42 Is there any perf improvement with this pr? Thanks.

@simon-mo simon-mo merged commit d331759 into vllm-project:main Aug 1, 2025
72 checks passed
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants