Skip to content

[Spec Decode] Make EAGLE3 draft token ID mapping optional #18488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025
Merged

[Spec Decode] Make EAGLE3 draft token ID mapping optional #18488

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b68d387
make EAGLE3 smaller vocab size optional
benchislett May 21, 2025
a190346
move d2t check into load_weights
benchislett May 21, 2025
185529d
Merge remote-tracking branch 'upstream/main' into eagle3-d2t-optional
benchislett May 21, 2025
c82465c
Update vllm/model_executor/models/llama_eagle3.py
benchislett May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion vllm/model_executor/models/llama_eagle3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ def compute_logits(
) -> Optional[torch.Tensor]:
logits = self.logits_processor(self.lm_head, hidden_states,
sampling_metadata)
if self.draft_id_to_target_id is None:
return logits

base = torch.arange(self.config.draft_vocab_size, device=logits.device)
targets = base + self.draft_id_to_target_id
logits_new = logits.new_full((
Expand Down Expand Up @@ -245,4 +248,10 @@ def load_weights(self, weights: Iterable[tuple[str, torch.Tensor]]):
name = "model." + name
model_weights[name] = loaded_weight

return loader.load_weights(model_weights.items())
loaded_weights = loader.load_weights(model_weights.items())

if 'd2t' not in loaded_weights:
del self.draft_id_to_target_id
self.draft_id_to_target_id = None

return loaded_weights