-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[Feature][V1] Support tool_choice: required when using Xgrammar as the StructuredOutputBackend.
#17845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
tool_choice: required when using Xgrammar as the StructuredOutputBackend.
a0f9f17 to
361a915
Compare
tool_choice: required when using Xgrammar as the StructuredOutputBackend.tool_choice: required when using Xgrammar as the StructuredOutputBackend.
b1f1075 to
741ff88
Compare
|
Where is the tool calling fix exactly? Is it that a bug fix was needed in xgrammar 0.19? |
Here. @russellb vllm/vllm/entrypoints/openai/protocol.py Lines 560 to 593 in 7d4aeda
"
xgrammar 0.19 supports |
|
/cc @russellb @DarkLight1337 PTAL. |
russellb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: chaunceyjiang <[email protected]>
…ructuredOutputBackend Signed-off-by: chaunceyjiang <[email protected]>
Head branch was pushed to by a user without write access
741ff88 to
ae98e83
Compare
|
Hi, @DarkLight1337 It seems that the failed CI checks are unrelated to my code. Could you help retry the CI? |
|
I think this can be merged. The failed CI seems to be environment-related. Other PRs have similar errors — for example, #18047 also failed on |
…the `StructuredOutputBackend`. (vllm-project#17845) Signed-off-by: chaunceyjiang <[email protected]>
…the `StructuredOutputBackend`. (vllm-project#17845) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
FIX #16887
Test