Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for quantization and qlora models? #906

Closed
thistleknot opened this issue Aug 29, 2023 · 4 comments
Closed

support for quantization and qlora models? #906

thistleknot opened this issue Aug 29, 2023 · 4 comments

Comments

@thistleknot
Copy link

would love to use this with quantization and adapters

@Miraclemarvel55
Copy link

yes quite need. that is amazing

@Gregory-Ledray
Copy link

I am not a maintainer.

This is a duplicate of #744

@LopezGG
Copy link

LopezGG commented Sep 4, 2023

I am using vllm with qlora. I merge the adapters with

model_for_merge = AutoModelForCausalLM.from_pretrained(
        base_model_path_or_name,
        torch_dtype=torch.float16,
    )
    full_model = PeftModel.from_pretrained(model_for_merge,
                                          model_id=script_args.adapter_dir,
                                        )
    full_model = full_model.base_model.merge_and_unload()  
    full_model.save_pretrained(script_args.full_model_dir)
    tokenizer.save_pretrained(script_args.full_model_dir)

and point vllm to this dir. Given that the A & B matrices are added to original weight matrices, there is no change in dimension or architecture. So, vllm can consume it. I would like a way to pass the model directly after load without saving it though

@hmellor
Copy link
Collaborator

hmellor commented Mar 8, 2024

Closing in favour of #3225 because quantization and LoRA are both supported. We just need QLoRA support.

@hmellor hmellor closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants