Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support for Registering Model-Specific Default Sampling Parameters #10539

Open
1 task done
yansh97 opened this issue Nov 21, 2024 · 1 comment
Open
1 task done

Comments

@yansh97
Copy link
Contributor

yansh97 commented Nov 21, 2024

🚀 The feature, motivation and pitch

When starting an OpenAI-compatible server, provide a specific set of sampling parameters to override the default parameters provided by vLLM.

Some model publishers (e.g., Qwen2.5) provide a set of parameters optimized for their model. Setting these parameters manually in the client for every request can be cumbersome, and forgetting to do so may result in incoherent outputs.

Do the maintainers of vLLM consider it necessary to allow registering such parameters along with the model, so they can override the default sampling parameters?

If deemed necessary, I am open to developing this feature and submitting a pull request.

Alternatives

No response

Additional context

https://huggingface.co/Qwen/Qwen2.5-7B-Instruct/blob/main/generation_config.json

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@yansh97
Copy link
Contributor Author

yansh97 commented Nov 21, 2024

Providing these parameters in generation_config seems to be a non-standard approach, making it impractical to parse this file for specific sampling parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant