Skip to content

Commit 4ab5f84

Browse files
committed
Some robustness fixes
- Remove extra white spaces after '\' on end of line. This shouldn't be an issue with the current command, but could make troubleshooting more difficult. - Use PYTHON_VERSION variable when copying to Python paths. Signed-off-by: Fabien Dupont <[email protected]>
1 parent 1f24ee1 commit 4ab5f84

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

docker/Dockerfile

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,8 @@ FROM vllm-base AS test
417417

418418
ADD . /vllm-workspace/
419419

420+
ARG PYTHON_VERSION
421+
420422
ARG PIP_INDEX_URL UV_INDEX_URL
421423
ARG PIP_EXTRA_INDEX_URL UV_EXTRA_INDEX_URL
422424

@@ -430,7 +432,7 @@ RUN --mount=type=cache,target=/root/.cache/uv \
430432
uv pip install --system --no-build-isolation "git+https://github.com/state-spaces/[email protected]"
431433

432434
# install development dependencies (for testing)
433-
RUN --mount=type=cache,target=/root/.cache/uv \
435+
RUN --mount=type=cache,target=/root/.cache/uv \
434436
CUDA_MAJOR="${CUDA_VERSION%%.*}"; \
435437
if [ "$CUDA_MAJOR" -ge 12 ]; then \
436438
uv pip install --system -r requirements/dev.txt; \
@@ -446,7 +448,7 @@ RUN --mount=type=cache,target=/root/.cache/uv \
446448
ENV HF_HUB_ENABLE_HF_TRANSFER 1
447449

448450
# Copy in the v1 package for testing (it isn't distributed yet)
449-
COPY vllm/v1 /usr/local/lib/python3.12/dist-packages/vllm/v1
451+
COPY vllm/v1 /usr/local/lib/python${PYTHON_VERSION}/dist-packages/vllm/v1
450452

451453
# doc requires source code
452454
# we hide them inside `test_docs/` , so that this source code

0 commit comments

Comments
 (0)