Skip to content

✨ add doc lint fix#164

Merged
rafvasq merged 1 commit intomainfrom
doc-lint-fix
May 16, 2025
Merged

✨ add doc lint fix#164
rafvasq merged 1 commit intomainfrom
doc-lint-fix

Conversation

@prashantgupta24
Copy link
Copy Markdown
Collaborator

@prashantgupta24 prashantgupta24 commented May 16, 2025

Adds a fix option for markdown linter. Works okay in most cases. Docs for it - https://pymarkdown.readthedocs.io/en/latest/user-guide/#fix-mode-failure-correction

Note: changes to the uv.lock file are big because uv introduced a big change here - astral-sh/uv#13176 . This changes all occurrences of upload_time to upload-time . Apart from that, the only actual change should be the version update for the doc linter.

Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Copy link
Copy Markdown
Collaborator

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think it'll help while we're at the very start of adding docs.

@rafvasq rafvasq merged commit c8c24ce into main May 16, 2025
19 checks passed
@rafvasq rafvasq deleted the doc-lint-fix branch May 16, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants