Conversation
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. Or this can be done with Now you are good to go 🚀 |
rafvasq
approved these changes
May 16, 2025
Collaborator
rafvasq
left a comment
There was a problem hiding this comment.
LGTM! I think it'll help while we're at the very start of adding docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
fixoption for markdown linter. Works okay in most cases. Docs for it - https://pymarkdown.readthedocs.io/en/latest/user-guide/#fix-mode-failure-correctionNote: changes to the
uv.lockfile are big because uv introduced a big change here - astral-sh/uv#13176 . This changes all occurrences ofupload_timetoupload-time. Apart from that, the only actual change should be the version update for the doc linter.