Skip to content

[CI] [Resource] Remove unused test cases to cutdown agent resources usage#2688

Merged
hsliuustc0106 merged 3 commits into
vllm-project:mainfrom
EmbeddedLLM:tuneresource
Apr 11, 2026
Merged

[CI] [Resource] Remove unused test cases to cutdown agent resources usage#2688
hsliuustc0106 merged 3 commits into
vllm-project:mainfrom
EmbeddedLLM:tuneresource

Conversation

@tjtanaa
Copy link
Copy Markdown
Member

@tjtanaa tjtanaa commented Apr 10, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Remove test cases that are running any tests to reduce resource consumption.

in test-ready.yml :

Omni Model Test (uses 4 GPUs instance)

https://buildkite.com/vllm/vllm-omni/builds/6331/steps/canvas?sid=019d77a2-0a20-4058-a024-bf435db98466&tab=output

================ 1 skipped, 1 deselected, 17 warnings in 0.04s =================

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@tjtanaa tjtanaa marked this pull request as ready for review April 10, 2026 16:14
@tjtanaa tjtanaa requested a review from hsliuustc0106 as a code owner April 10, 2026 16:14
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copy link
Copy Markdown
Collaborator

@hsliuustc0106 hsliuustc0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out rather than deleting -- intentional? If this is temporary, consider adding a date annotation so it doesn't rot forever. Also, the H100 variant is still active, so L4 coverage is being lost. Is that acceptable? If the H100 test covers the same ground, the commented-out block should just be deleted.

@tjtanaa
Copy link
Copy Markdown
Member Author

tjtanaa commented Apr 11, 2026

Commenting out rather than deleting -- intentional? If this is temporary, consider adding a date annotation so it doesn't rot forever. Also, the H100 variant is still active, so L4 coverage is being lost. Is that acceptable? If the H100 test covers the same ground, the commented-out block should just be deleted.

I am not the person who setup this test. So I would not want to remove the test completely, do you know who would be the best person to ask if we want to remove this completely?

@hsliuustc0106
Copy link
Copy Markdown
Collaborator

@yenuo26 PTAL

tjtanaa added 2 commits April 11, 2026 12:27
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@tjtanaa
Copy link
Copy Markdown
Member Author

tjtanaa commented Apr 11, 2026

@yenuo26 Thanks for the feedback. I have completely removed the test. Ready for review.

@tjtanaa tjtanaa changed the title [CI] [Resource] Remove unused test cases to cutdown agent resources [CI] [Resource] Remove unused test cases to cutdown agent resources usage Apr 11, 2026
@hsliuustc0106 hsliuustc0106 merged commit 6e93595 into vllm-project:main Apr 11, 2026
3 checks passed
daixinning pushed a commit to daixinning/vllm-omni that referenced this pull request Apr 13, 2026
…sage (vllm-project#2688)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
lengrongfu pushed a commit to lengrongfu/vllm-omni that referenced this pull request May 1, 2026
…sage (vllm-project#2688)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
…sage (vllm-project#2688)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants