[CI] [Resource] Remove unused test cases to cutdown agent resources usage#2688
Conversation
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
hsliuustc0106
left a comment
There was a problem hiding this comment.
Commenting out rather than deleting -- intentional? If this is temporary, consider adding a date annotation so it doesn't rot forever. Also, the H100 variant is still active, so L4 coverage is being lost. Is that acceptable? If the H100 test covers the same ground, the commented-out block should just be deleted.
I am not the person who setup this test. So I would not want to remove the test completely, do you know who would be the best person to ask if we want to remove this completely? |
|
@yenuo26 PTAL |
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
|
@yenuo26 Thanks for the feedback. I have completely removed the test. Ready for review. |
…sage (vllm-project#2688) Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
…sage (vllm-project#2688) Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
…sage (vllm-project#2688) Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Remove test cases that are running any tests to reduce resource consumption.
in test-ready.yml :
Omni Model Test (uses 4 GPUs instance)
https://buildkite.com/vllm/vllm-omni/builds/6331/steps/canvas?sid=019d77a2-0a20-4058-a024-bf435db98466&tab=output
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)