Skip to content

Revert "[Fix] Fix slow hasattr in CUDAGraphWrapper.__getattr__ (#1982)"#2639

Merged
hsliuustc0106 merged 1 commit into
vllm-project:mainfrom
ZeldaHuang:revert_pr1982
Apr 9, 2026
Merged

Revert "[Fix] Fix slow hasattr in CUDAGraphWrapper.__getattr__ (#1982)"#2639
hsliuustc0106 merged 1 commit into
vllm-project:mainfrom
ZeldaHuang:revert_pr1982

Conversation

@ZeldaHuang
Copy link
Copy Markdown
Collaborator

This reverts commit 89fff09.

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

ref #1982 (comment)

Test Plan

vllm bench serve \
  --omni \
  --dataset-name random \
  --port 8091 \
  --max-concurrency 1 \
  --model /mnt/data/models/Qwen3-Omni-30B-A3B-Instruct/ \
  --endpoint /v1/chat/completions \
  --backend openai-chat-omni \
  --num-prompts 1 \
  --random-input-len 8000 \
  --ignore-eos \
  --percentile-metrics ttft,tpot,itl,e2el,audio_ttfp,audio_rtf \
  --random-output-len 100 \
  --extra_body '{"modalities": ["text", "audio"]}'

Test Result

Before revert:

============ Serving Benchmark Result ============
Successful requests:                     1         
Failed requests:                         0         
Maximum request concurrency:             1         
Benchmark duration (s):                  5.23      
Request throughput (req/s):              0.19      
Peak concurrent requests:                1.00      
----------------End-to-end Latency----------------
Mean E2EL (ms):                          5230.39   
Median E2EL (ms):                        5230.39   
P99 E2EL (ms):                           5230.39   
================== Text Result ===================
Total input tokens:                      8014      
Total generated tokens:                  100       
Output token throughput (tok/s):         19.12     
Peak output token throughput (tok/s):    79.00     
Peak concurrent requests:                1.00      
Total Token throughput (tok/s):          1551.16   
---------------Time to First Token----------------
Mean TTFT (ms):                          775.89    
Median TTFT (ms):                        775.89    
P99 TTFT (ms):                           775.89    
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          9.84      
Median TPOT (ms):                        9.84      
P99 TPOT (ms):                           9.84      
---------------Inter-token Latency----------------
Mean ITL (ms):                           9.74      
Median ITL (ms):                         9.73      
P99 ITL (ms):                            41.08     
================== Audio Result ==================
Total audio duration generated(s):       24.42     
Total audio frames generated:            586065    
Audio throughput(audio duration/s):      4.67      
---------------Time to First Packet---------------
Mean AUDIO_TTFP (ms):                    1492.09   
Median AUDIO_TTFP (ms):                  1492.09   
P99 AUDIO_TTFP (ms):                     1492.09   
-----------------Real Time Factor-----------------
Mean AUDIO_RTF:                          0.21      
Median AUDIO_RTF:                        0.21      
P99 AUDIO_RTF:                           0.21      
==================================================

After revert:

============ Serving Benchmark Result ============
Successful requests:                     1         
Failed requests:                         0         
Maximum request concurrency:             1         
Benchmark duration (s):                  5.43      
Request throughput (req/s):              0.18      
Peak concurrent requests:                1.00      
----------------End-to-end Latency----------------
Mean E2EL (ms):                          5425.66   
Median E2EL (ms):                        5425.66   
P99 E2EL (ms):                           5425.66   
================== Text Result ===================
Total input tokens:                      8014      
Total generated tokens:                  100       
Output token throughput (tok/s):         18.43     
Peak output token throughput (tok/s):    75.00     
Peak concurrent requests:                1.00      
Total Token throughput (tok/s):          1495.33   
---------------Time to First Token----------------
Mean TTFT (ms):                          748.53    
Median TTFT (ms):                        748.53    
P99 TTFT (ms):                           748.53    
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          9.72      
Median TPOT (ms):                        9.72      
P99 TPOT (ms):                           9.72      
---------------Inter-token Latency----------------
Mean ITL (ms):                           9.63      
Median ITL (ms):                         9.74      
P99 ITL (ms):                            49.61     
================== Audio Result ==================
Total audio duration generated(s):       25.70     
Total audio frames generated:            616785    
Audio throughput(audio duration/s):      4.74      
---------------Time to First Packet---------------
Mean AUDIO_TTFP (ms):                    1483.27   
Median AUDIO_TTFP (ms):                  1483.27   
P99 AUDIO_TTFP (ms):                     1483.27   
-----------------Real Time Factor-----------------
Mean AUDIO_RTF:                          0.21      
Median AUDIO_RTF:                        0.21      
P99 AUDIO_RTF:                           0.21      
==================================================

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copy link
Copy Markdown
Collaborator

@hsliuustc0106 hsliuustc0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gcanlin gcanlin added the ready label to trigger buildkite CI label Apr 9, 2026
@gcanlin gcanlin enabled auto-merge (squash) April 9, 2026 09:18
@hsliuustc0106 hsliuustc0106 disabled auto-merge April 9, 2026 09:19
@hsliuustc0106 hsliuustc0106 merged commit d2aa9cf into vllm-project:main Apr 9, 2026
5 of 8 checks passed
vraiti pushed a commit to vraiti/vllm-omni that referenced this pull request Apr 9, 2026
Sy0307 pushed a commit to Sy0307/vllm-omni that referenced this pull request Apr 10, 2026
daixinning pushed a commit to daixinning/vllm-omni that referenced this pull request Apr 13, 2026
lengrongfu pushed a commit to lengrongfu/vllm-omni that referenced this pull request May 1, 2026
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants