[Build][Bugfix] Fix source code path to avoid reference error #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxiyuan
reviewed
Apr 30, 2025
| rm -rf /var/cache/apt/* && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| WORKDIR /workspace |
Collaborator
There was a problem hiding this comment.
So this workspace is useless now? we better use /root as the default to keep the same with 0.8.4rc2 @Yikun
Collaborator
Author
There was a problem hiding this comment.
Just FYI, vllm keep the entry path /workspace of the container.
https://github.com/vllm-project/vllm/blob/main/docker/Dockerfile#L55
Member
There was a problem hiding this comment.
Yes, we'd better follow vLLM repo to keep user experience, we can note some on 0.8.4rc2 and 0.8.5rc1 release note to show this.
Member
|
Please also add
to make sure This PR should also sync to v0.7.3 |
Signed-off-by: MengqingCao <[email protected]>
Yikun
approved these changes
Apr 30, 2025
Yikun
pushed a commit
that referenced
this pull request
Apr 30, 2025
…#741) Backport and sync dockerfile change #726 This patch follow vLLM, move all source code into /vllm-workspace/, and keep /workspace as workdir. [1] https://github.com/vllm-project/vllm/blob/main/docker/Dockerfile#L264C7-L264C23 [2] https://github.com/vllm-project/vllm/blob/main/docker/Dockerfile#L52 Closes: #725 Signed-off-by: MengqingCao <[email protected]>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
…roject#726) ### What this PR does / why we need it? Fix source code path to avoid reference error in docker image fix vllm-project#725 Signed-off-by: MengqingCao <[email protected]>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
…roject#726) ### What this PR does / why we need it? Fix source code path to avoid reference error in docker image fix vllm-project#725 Signed-off-by: MengqingCao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Fix source code path to avoid reference error in docker image
fix #725