-
Notifications
You must be signed in to change notification settings - Fork 622
[CI] Fix test on pyhccl to 2 cards #2094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: MengqingCao <[email protected]>
Yikun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if multicard CI passed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2094 +/- ##
=======================================
Coverage 73.68% 73.68%
=======================================
Files 96 96
Lines 10920 10920
=======================================
Hits 8046 8046
Misses 2874 2874
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Test locally, let's merge this directly to recover CI cc @ganyi1996ppo @jianzs @wangxiyuan Failure introduced here: 4df8e00 , because the CI passed before f60bb47 root@7ec57ea5edb1:/vllm-workspace/vllm-ascend# git diff
diff --git a/tests/e2e/multicard/test_pyhccl_distributed.py b/tests/e2e/multicard/test_pyhccl_distributed.py
index e3d9aed..2300e0a 100644
--- a/tests/e2e/multicard/test_pyhccl_distributed.py
+++ b/tests/e2e/multicard/test_pyhccl_distributed.py
@@ -89,7 +89,7 @@ def worker_fn():
def test_pyhccl():
- distributed_run(worker_fn, 4)
+ distributed_run(worker_fn, 2)
def broadcast_worker_fn():
@@ -118,4 +118,4 @@ def broadcast_worker_fn():
def test_pyhccl_broadcast():
- distributed_run(broadcast_worker_fn, 4)
+ distributed_run(broadcast_worker_fn, 2) |
### What this PR does / why we need it? Fix test on pyhccl to 2 cards ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@0d0cc9e Signed-off-by: MengqingCao <[email protected]>
### What this PR does / why we need it? Fix test on pyhccl to 2 cards ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@0d0cc9e Signed-off-by: MengqingCao <[email protected]> Signed-off-by: weijinqian_v1 <[email protected]>
### What this PR does / why we need it? Fix test on pyhccl to 2 cards ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@0d0cc9e Signed-off-by: MengqingCao <[email protected]>
### What this PR does / why we need it? Fix test on pyhccl to 2 cards ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@0d0cc9e Signed-off-by: MengqingCao <[email protected]>
What this PR does / why we need it?
Fix test on pyhccl to 2 cards
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
CI passed with existing test.