From 43fb71edc405c46b7901f36706c0a8d0df6c05f9 Mon Sep 17 00:00:00 2001 From: Andreas Karatzas Date: Tue, 24 Feb 2026 17:05:48 -0600 Subject: [PATCH 1/2] [ROCm] Added all current MI3XX agents Signed-off-by: Andreas Karatzas --- .../pipeline_generator/buildkite_step.py | 22 ++++++++++++------- buildkite/pipeline_generator/constants.py | 13 ++++++++++- 2 files changed, 26 insertions(+), 9 deletions(-) diff --git a/buildkite/pipeline_generator/buildkite_step.py b/buildkite/pipeline_generator/buildkite_step.py index fd82b78f..5ce1edd3 100644 --- a/buildkite/pipeline_generator/buildkite_step.py +++ b/buildkite/pipeline_generator/buildkite_step.py @@ -303,15 +303,21 @@ def _create_amd_mirror_step(step: Step, original_commands: List[str], amd: Dict[ device_type = amd_device.replace("amd_", "") if amd_device.startswith("amd_") else amd_device amd_label = f"AMD: {step.label} ({device_type})" - # Get AMD queue name from device name - amd_queue = None - if amd_device == DeviceType.AMD_MI325_1: - amd_queue = AgentQueue.AMD_MI325_1 - elif amd_device == DeviceType.AMD_MI325_8: - amd_queue = AgentQueue.AMD_MI325_8 - + # Map device type to agent queue + amd_queue_map = { + DeviceType.AMD_MI325_1: AgentQueue.AMD_MI325_1, + DeviceType.AMD_MI325_2: AgentQueue.AMD_MI325_2, + DeviceType.AMD_MI325_4: AgentQueue.AMD_MI325_4, + DeviceType.AMD_MI325_8: AgentQueue.AMD_MI325_8, + DeviceType.AMD_MI355_1: AgentQueue.AMD_MI355_1, + DeviceType.AMD_MI355_2: AgentQueue.AMD_MI355_2, + DeviceType.AMD_MI355_4: AgentQueue.AMD_MI355_4, + DeviceType.AMD_MI355_8: AgentQueue.AMD_MI355_8, + } + + amd_queue = amd_queue_map.get(amd_device) if not amd_queue: - raise ValueError(f"Invalid device: {amd_device}") + raise ValueError(f"Invalid AMD device: {amd_device}. Valid devices: {list(amd_queue_map.keys())}") amd_retry = { "automatic": [ diff --git a/buildkite/pipeline_generator/constants.py b/buildkite/pipeline_generator/constants.py index 99bc52b8..77afa6e1 100644 --- a/buildkite/pipeline_generator/constants.py +++ b/buildkite/pipeline_generator/constants.py @@ -15,8 +15,13 @@ class DeviceType(str, Enum): ASCEND = "ascend_npu" AMD_CPU = "amd_cpu" AMD_MI325_1 = "mi325_1" + AMD_MI325_2 = "mi325_2" + AMD_MI325_4 = "mi325_4" AMD_MI325_8 = "mi325_8" - + AMD_MI355_1 = "mi355_1" + AMD_MI355_2 = "mi355_2" + AMD_MI355_4 = "mi355_4" + AMD_MI355_8 = "mi355_8" class AgentQueue(str, Enum): @@ -41,4 +46,10 @@ class AgentQueue(str, Enum): ASCEND = "ascend" AMD_CPU = "amd-cpu" AMD_MI325_1 = "amd_mi325_1" + AMD_MI325_2 = "amd_mi325_2" + AMD_MI325_4 = "amd_mi325_4" AMD_MI325_8 = "amd_mi325_8" + AMD_MI355_1 = "amd_mi355_1" + AMD_MI355_2 = "amd_mi355_2" + AMD_MI355_4 = "amd_mi355_4" + AMD_MI355_8 = "amd_mi355_8" From f05e86c56efa44f7c7e68128269c8c6148b1004f Mon Sep 17 00:00:00 2001 From: Andreas Karatzas Date: Tue, 24 Feb 2026 18:40:47 -0600 Subject: [PATCH 2/2] Fix NoneType error in source_file_dependencies when step omits the field Signed-off-by: Andreas Karatzas --- buildkite/pipeline_generator/step.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/buildkite/pipeline_generator/step.py b/buildkite/pipeline_generator/step.py index 28ffa926..ffcf2aef 100644 --- a/buildkite/pipeline_generator/step.py +++ b/buildkite/pipeline_generator/step.py @@ -70,7 +70,8 @@ def read_steps_from_job_dir(job_dir: str): and global_config["github_repo_name"] == "vllm-project/vllm" ): step.working_dir = "/vllm-workspace/tests" - step.source_file_dependencies = getattr(step, "source_file_dependencies", []) + if step.source_file_dependencies is None: + step.source_file_dependencies = [] step.source_file_dependencies.append(os.path.relpath(yaml_path)) steps.extend(file_steps) return steps