Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] making double arrows available in day view #501

Open
albancho opened this issue Apr 28, 2020 · 2 comments
Open

[Feature Request] making double arrows available in day view #501

albancho opened this issue Apr 28, 2020 · 2 comments

Comments

@albancho
Copy link

Hello there,

This PR made a double arrow available in the month view, to navigate multiple years back/forward, with showMultipleYearsNavigation and multipleYearsNavigateBy parameters.

What about being able to navigate by year in the day picker ?

The simple arrow would do "+/- 1 month", and double arrow would do "+/- 1 year".

It seems possible to reuse what has been done with showMultipleYearsNavigation, using multipleYearsNavigateBy = 1. So all we would have to do, is add the code which is in the month picker to the day picker.

To be closer to the month behavior, multipleYearsNavigateBy could define a number of month, instead of a number of year. So setting a value of "12" would do "+/- 1 year", but the parameter should then change its name...

In the code, the button is called "Left/rightSecondaryButton", so the parameters could be showSecondaryNavigation, and secondaryNavigationStep ?

I would love to make a PR about this, if you could tell me which branch to base onto.

@vlio20
Copy link
Owner

vlio20 commented Apr 28, 2020

This is a great idea. Please PR it to the next branch.
Don't forget to add unit + e2e tests and documentation.

I am here for any question.

@albancho
Copy link
Author

albancho commented Apr 29, 2020

Nice,
@vlio20 I made PR #502.
Strange thing is that the fork does not include the next branch, but ok in PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants