fix hanging on windows #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Sep 29, 2024
spytheman
reviewed
Sep 29, 2024
| // test_file := 'file:///c%3A/Users/phcre/Documents/v/imageeditor/testing/proc.v' | ||
| dump(test_file) | ||
|
|
||
| src := os.read_file(test_file) or { panic('Cannot read file') } |
There was a problem hiding this comment.
os.read_file handles relative and absolute paths, like the ones returned by os.real_path .
spytheman
reviewed
Sep 29, 2024
src/server/features_formatting.v
Outdated
Comment on lines
17
to
32
| mut fmt_proc := ls.launch_tool('fmt', temp_formatting_file_path)! | ||
| loglib.info('Formatting file: ${temp_formatting_file_path} ${file.uri}') | ||
|
|
||
| mut fmt_proc := ls.launch_tool('fmt', os.norm_path(temp_formatting_file_path)) or { return [] } | ||
| defer { | ||
| fmt_proc.close() | ||
| } | ||
| fmt_proc.run() | ||
|
|
||
| // read entire output until EOF | ||
| mut output := fmt_proc.stdout_slurp() | ||
| fmt_proc.wait() | ||
|
|
||
| if fmt_proc.code != 0 { | ||
| loglib.info('Formatting finished with code: ${fmt_proc.code} and status ${fmt_proc.status}') | ||
|
|
||
| $if windows { | ||
| output = output.replace('\r\r', '\r') | ||
| } | ||
|
|
||
| if (fmt_proc.code != 0) && (fmt_proc.status == .exited) { | ||
| errors := fmt_proc.stderr_slurp().trim_space() | ||
| ls.client.show_message(errors, .info) | ||
| return error('Formatting failed: ${errors}') | ||
| // return [] | ||
| } | ||
|
|
||
| mut output := fmt_proc.stdout_slurp() | ||
| $if windows { | ||
| output = output.replace('\r\r', '\r') | ||
| } |
There was a problem hiding this comment.
that is complicated for no reason. Just res := os.execute('v fmt file.v') and then using res.exit_code and res.output should be enough.
There was a problem hiding this comment.
Is the goal avoiding reading from stderr?
There was a problem hiding this comment.
I did not write this originally but I believe that is the case. the stdout gets sent to the IDE and is used to replace the text in the buffer. the stderr, if caught, gets sent to the IDE as a warning notification/highlighting. I do think os.execute would work but it is essentially the same thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #128
vfmt on large files fills the stdout output buffer but v-analyzer does not read the buffer until vfmt exits.