Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting buttons should always insert formatting symbols #1598

Closed
Tracked by #1541
HeyMyian opened this issue Nov 12, 2023 · 1 comment · Fixed by #1600
Closed
Tracked by #1541

Formatting buttons should always insert formatting symbols #1598

HeyMyian opened this issue Nov 12, 2023 · 1 comment · Fixed by #1600
Assignees
@vkbo
Labels
editor Component: Editor enhancement Request: New feature or improvement next release Note: Features planned for next release
Milestone
Release 2.2 RC 1

Comments

@HeyMyian
Copy link
Contributor

HeyMyian commented Nov 12, 2023 •
edited
Loading

Clicking on the formatting buttons in the new toolbar currently does nothing when

  1. no word is selected or
  2. the cursor is not inside of or at the end of a word.

The expected result however is to insert the formatting symbols with the cursor placed inside them, ready to type.

Originally posted in #1596 (comment)
@vkbo vkbo self-assigned this Nov 12, 2023
@vkbo vkbo added enhancement Request: New feature or improvement editor Component: Editor next release Note: Features planned for next release labels Nov 12, 2023
@vkbo vkbo added this to the Release 2.2 RC 1 milestone Nov 12, 2023
This was referenced Nov 12, 2023
Closed
Merged
@vkbo vkbo linked a pull request Nov 12, 2023 that will close this issue
Improve how formatting is applied in the editor #1600
Merged
6 tasks
@vkbo
Copy link
Owner

vkbo commented Nov 12, 2023 •
edited
Loading

Fixed in #1600, alongside a general improvement of how formatting is applied. Needs testing to see that there are no corner cases it misses.

@vkbo vkbo closed this as completed Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vkbo vkbo

Labels
editor Component: Editor enhancement Request: New feature or improvement next release Note: Features planned for next release
Projects
None yet
Milestone
Release 2.2 RC 1
Development

Successfully merging a pull request may close this issue.

Improve how formatting is applied in the editor vkbo/novelWriter
2 participants
@vkbo @HeyMyian