Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hideable formatting toolbar for shortcodes #1585

Closed
Tracked by #1541
vkbo opened this issue Nov 8, 2023 · 4 comments · Fixed by #1584
Closed
Tracked by #1541

Add a hideable formatting toolbar for shortcodes #1585

vkbo opened this issue Nov 8, 2023 · 4 comments · Fixed by #1584

Comments

@vkbo
Copy link
Owner

vkbo commented Nov 8, 2023

With a lot of formatting options incoming, it may be time for adding a toolbar to the document editor. I propose that it is vertical along the left edge, and only visible when the user wants it to. So, there needs to be a toggle button for it. The current edit button, which is pretty much redundant now, can be replaced with a show/hide toolbar button.

@vkbo vkbo added this to the Release 2.2 Beta 1 milestone Nov 8, 2023
@vkbo vkbo linked a pull request Nov 8, 2023 that will close this issue
6 tasks
@vkbo
Copy link
Owner Author

vkbo commented Nov 8, 2023

Implementation in #1584 looks like this now:

image

@vkbo vkbo changed the title Add a hidable formatting toolbar for shortcodes Add a hideable formatting toolbar for shortcodes Nov 8, 2023
@marek-lach
Copy link

With a lot of formatting options incoming, it may be time for adding a toolbar to the document editor. I propose that it is vertical along the left edge, and only visible when the user wants it to. So, there needs to be a toggle button for it. The current edit button, which is pretty much redundant now, can be replaced with a show/hide toolbar button.

I only wanted to ask, if it could be adjustable through settings if the formatting toolbar would be on the left (by default), or the right edge...

@vkbo
Copy link
Owner Author

vkbo commented Nov 9, 2023

It appears below the three dots button. Any particular reason to put it on the other side? You wouldn't usually have it open. The only reason I didn't just add it as a dropdown menu, as I originally had intended, is that this is easier to use and access.

@marek-lach
Copy link

It appears below the three dots button. Any particular reason to put it on the other side? You wouldn't usually have it open. The only reason I didn't just add it as a dropdown menu, as I originally had intended, is that this is easier to use and access.

It's a nice design. And no big deal to leave it where it is. I was just thinking about left/right handed people...

@vkbo vkbo closed this as completed Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants