Mark cleaned strings as html safe #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjt
added a commit
that referenced
this pull request
Mar 14, 2014
Mark cleaned strings as html safe, bootstrap test suite
|
Man, you're awesome. ❤️ 🍻 |
|
No problemo, thanks for managing the hard work of actually building this gem. Testing it after the fact isn't too tricky, it's just a matter of putting together some sanity checks and adding new ones for the changes I made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a technical limitation, I'm unable to mark strings that call
Sanitize::Rails::Engine.clean!as html_safe; there is no clean way to change an instance ofStringin place into an instance ofActiveSupport::SafeBuffer. That being said,Sanitize::Rails::Engine.cleannow marks any text passed through it as html_safe!Additionally, this branch stubs out a new test suite. For now it just verifies the behavior of
Sanitize::Rails::Engineand theSanitize::Rails::Stringextension, but I think that's comprehensive enough to give me confidence that the changes presented here won't break anything.Lastly, I've initialized a TravisCI configuration. Once this is merged in you should see CI builds start to pop up under https://travis-ci.org/vjt/sanitize-rails. And yes, a build status badge has indeed been added to the README. Enjoy!
https://github.com/damien/sanitize-rails/tree/4-mark-cleaned-strings-as-html-safe:
EDIT: This pull request fixes #4