Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"SanitizeFieldsMatcher implements a legacy RSpec matcher protocol" #13

Closed
thbar opened this issue Dec 10, 2014 · 4 comments
Closed

"SanitizeFieldsMatcher implements a legacy RSpec matcher protocol" #13

thbar opened this issue Dec 10, 2014 · 4 comments

Comments

@thbar
Copy link

thbar commented Dec 10, 2014

When using sanitize-rails with RSpec 3.1.0, I get this warning:

Deprecation Warnings:

--------------------------------------------------------------------------------
Sanitize::Rails::Matchers::SanitizeFieldsMatcher implements a legacy RSpec matcher
protocol. For the current protocol you should expose the failure messages
via the `failure_message` and `failure_message_when_negated` methods.
(Used from /Volumes/Customer/apps/application/spec/models/my_spec.rb:5:in `block (2 levels) in <top (required)>')
--------------------------------------------------------------------------------
@damien
Copy link
Contributor

damien commented Feb 10, 2015

@thbar Could you provide a stacktrace for this? I think I know what might be causing this, but it'd be useful to have a test case to reproduce this before anybody takes a stab at the issue.

@thbar
Copy link
Author

thbar commented Feb 10, 2015

@damien I will see if I can trace which app this came from (since I maintain several apps). If I see the log again, I will push the full stacktrace here. Thanks!

@damien
Copy link
Contributor

damien commented Feb 11, 2015

No problem. I'd hazard a guess that we just need to update things to work with newer versions of RSpec; it's been a while since the matchesrs in this gem were updated.

@vjt
Copy link
Owner

vjt commented Apr 24, 2015

Fixed in 91a460e, props to @fabn 🍻 😃

@vjt vjt closed this as completed Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants