Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Audio speed field not cleared when starting new song #44

Closed
BlobCodes opened this issue Dec 16, 2023 · 3 comments
Closed

Audio speed field not cleared when starting new song #44

BlobCodes opened this issue Dec 16, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@BlobCodes
Copy link
Contributor

When opening a new song with decibels while another song is playing, the currently playing song gets replaced (not sure if that's a good thing, but that's not what this issue is about).

If the previously playing audio file was played at a different speed, the input field showing this value does not get reset, even though the new song is clearly playing at normal (x1.0) speed.

Here's a video demonstrating the issue:

Bildschirmaufzeichnung.vom.2023-12-16.02-13-18.webm
@vixalien
Copy link
Owner

Thanks for reporting this!

@vixalien vixalien added bug Something isn't working good first issue Good for newcomers labels Dec 16, 2023
@vixalien
Copy link
Owner

This issue can be solved by notifying the player that the playback rate changed after the uri-loaded signal.

The handler is here:

decibels/src/stream.ts

Lines 529 to 532 in 686f2bc

private uri_loaded_cb(_play: GstPlay.Play, uri: string): void {
this.emit("loaded");
this.play();
}

What needs to be done is add a this.notify("rate") here. PRs are welcome!

@BlobCodes
Copy link
Contributor Author

Fixed by #45

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants