Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to fix desync from BPMCHANGE in songs previously converted by tja2bin #65

Open
vivaria opened this issue Feb 4, 2024 · 0 comments
Labels
feature New feature or request

Comments

@vivaria
Copy link
Owner

vivaria commented Feb 4, 2024

In #64, I added the ability to run tja2fumen on .bin charts, fixing the don/ka types based on timing, for previously-converted bins that don't have the correct don/ka values.

In theory, I could take this further, for example by checking for BPM changes between measures and re-computing the offset values. This should fix desync caused by the old tja2bin, see: Fluto/TakoTako#16

I don't know whether this is wanted, though, so I will leave this for now unless someone specifically asks for it.

@vivaria vivaria added the feature New feature or request label Feb 4, 2024
@vivaria vivaria changed the title Add feature to fix BPM of songs previously converted by tja2bin Add feature to fix desync from BPMCHANGE in songs previously converted by tja2bin Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant