Skip to content

Conversation

@termorey
Copy link
Contributor

@termorey termorey commented Nov 7, 2025

Description

Incorrect imports chain with missed file - missed types with "preview" provider (provider: preview()).
Thats not effect on local version - influenced npm (for example).

Example / Issue

Following documentation for implement vitest with browser mode: implementation.
As result file src/vitest-example/HelloWorld.test.ts has error:

Property 'getByText' does not exist on type 'RenderResult'.

Reason

vitest-browser-react src/pure.ts

import { page, utils } from 'vitest/browser' // vitest/browser context.d.ts
const { debug, getElementLocatorSelectors } = utils
// ...
export async function render(...args) {
 return {
  //...
  ...getElementLocatorSelectors(baseElement),
 }
}

vitest package.json exports ./browser
vitest browser/context.d.ts

export * from '@vitest/browser-preview/context' // MISSED FILE USAGE @vitest/browser-preview/condext.d.ts
export { BrowserCommands, FsOptions } from 'vitest/internal/browser'

@vitest/browser-preview package.json exports
@vitest/browser-preview package.json files

Solution

Changed package.json file: added context.d.ts into "files" (same as others providers do)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Changes can't be checked by exist tests. Failed without changes on ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @vitest/test-watch@ test: vitest

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Nov 7, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d146969
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/690dc2f97fe4fe0008a5b2dd
😎 Deploy Preview https://deploy-preview-8965--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you.

@sheremet-va sheremet-va merged commit 9044d93 into vitest-dev:main Nov 7, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants