feat(reporter): add onWritePath option to github-actions
#8015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Sorry, I hit Cmd-Enter before I was done updating the PR description. Working on that now! |
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
nwalters512
force-pushed
the
github-actions-reporter-on-write-path
branch
from
4172158 to
04db6fd
Compare
nwalters512
force-pushed
the
github-actions-reporter-on-write-path
branch
from
04db6fd to
ea956ad
Compare
AriPerkkio
changed the title
onWritePath option in GithubActionsReporteronWritePath option to github-actions
AriPerkkio
requested changes
May 23, 2025
AriPerkkio
force-pushed
the
github-actions-reporter-on-write-path
branch
from
5ab4e51 to
188cf18
Compare
AriPerkkio
approved these changes
May 25, 2025
Member
AriPerkkio
left a comment
AriPerkkio
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the PR @nwalters512! 💯
sheremet-va
approved these changes
May 26, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for an
onWritePathoption for the GitHub Actions reporter. This can be used to customize the path that's written in GitHub's annotation command format. This names was taken fromvitest-sonar-reporteras suggested by this comment: #8008 (comment).This is useful for situations where tests might be run such that their paths don't match the paths that GitHub sees. For instance, if the tests are being run in a container, the paths might start with
/app/, which GitHub can't map to a specific file in order to attach the annotation.Closes #8008.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.