Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable ESBuild when user config disables it #4492

Merged
merged 3 commits into from
Nov 13, 2023
Merged

fix: disable ESBuild when user config disables it #4492

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19e62ed
Merge branch 'main' of github.com:vitest-dev/vitest
Namchee Nov 13, 2023
8d81f30
fix(plugin): disable esbuild if user config sets it to false
Namchee Nov 13, 2023
ccc9241
fix(plugin): do not merge config
Namchee Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/vitest/src/node/plugins/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,15 @@ export async function VitestPlugin(options: UserConfig = {}, ctx = new Vitest('t

const config: ViteConfig = {
root: viteConfig.test?.root || options.root,
esbuild: {
sourcemap: 'external',

// Enables using ignore hint for coverage providers with @preserve keyword
legalComments: 'inline',
},
esbuild: viteConfig.esbuild === false
? false
: {
...viteConfig.esbuild,
Namchee marked this conversation as resolved.
Show resolved Hide resolved
sourcemap: 'external',

// Enables using ignore hint for coverage providers with @preserve keyword
legalComments: 'inline',
},
resolve: {
// by default Vite resolves `module` field, which not always a native ESM module
// setting this option can bypass that and fallback to cjs version
Expand Down