Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support shard in browser mode #4443

Closed
4 tasks done
tim-smart opened this issue Nov 5, 2023 · 3 comments
Closed
4 tasks done

Support shard in browser mode #4443

tim-smart opened this issue Nov 5, 2023 · 3 comments
Labels
feat: browser Issues and PRs related to the browser runner

Comments

@tim-smart
Copy link
Contributor

Clear and concise description of the problem

Currently passing a shard config to vitest in browser mode changes nothing.

Suggested solution

The browser runner should only run a portion of the tests if shard is provided.

Alternative

No response

Additional context

No response

Validations
@tim-smart tim-smart changed the title Support shard in browser mode. Support shard in browser mode Nov 5, 2023
@tim-smart
Copy link
Contributor Author

Failing test added here: #4444

@tim-smart
Copy link
Contributor Author

Updated PR to use sequencer for browser tests.

@Aslemammad Aslemammad added the feat: browser Issues and PRs related to the browser runner label Nov 27, 2023
@sheremet-va
Copy link
Member

Implemented in #4417

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feat: browser Issues and PRs related to the browser runner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tim-smart @sheremet-va @Aslemammad