Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy DOM v11 uses a virtual console #4089

Closed
6 tasks done
capricorn86 opened this issue Sep 7, 2023 · 0 comments · Fixed by #4090
Closed
6 tasks done

Happy DOM v11 uses a virtual console #4089

capricorn86 opened this issue Sep 7, 2023 · 0 comments · Fixed by #4090

Comments

@capricorn86
Copy link
Contributor

capricorn86 commented Sep 7, 2023

Describe the bug

In [email protected] a new virtual console was introduced. We need to send in the Node.js console to the constructor of the Happy DOM window instance as an option to keep the current behavior (which is also how it is done for JSDOM).

Reproduction

  1. Update to [email protected]
  2. Print errors or log entries to the console

Expected
The Happy DOM console outputs to the terminal.

Actual
Nothing from the Happy DOM console is outputted.

System Info

System:
    OS: Linux 6.2 Ubuntu 23.04 23.04 (Lunar Lobster)
    CPU: (4) x64 Intel(R) Core(TM) i5-7600K CPU @ 3.80GHz
    Memory: 7.96 GB / 15.57 GB
    Container: Yes
    Shell: 5.2.15 - /bin/bash
  Binaries:
    Node: 16.20.1 - ~/.nvm/versions/node/v16.20.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.20.1/bin/yarn
    npm: 8.19.4 - ~/.nvm/versions/node/v16.20.1/bin/npm
  Browsers:
    Chrome: 116.0.5845.179
    Chromium: 116.0.5845.140

Used Package Manager

npm

Validations

@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant