feat(vitest): stop using NODE_ENV to set vitest mode

vitest-dev · Oct 30, 2023 · 3c4c9ce · 3c4c9ce
1 parent 51b3c43
commit 3c4c9ce
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/packages/vitest/src/node/cli-api.ts b/packages/vitest/src/node/cli-api.ts
@@ -28,7 +28,7 @@ export async function startVitest(
 ): Promise<Vitest | undefined> {
   process.env.TEST = 'true'
   process.env.VITEST = 'true'
-  process.env.NODE_ENV ??= options.mode || 'test'
+  process.env.NODE_ENV ??= 'test'
 
   if (options.run)
     options.watch = false

diff --git a/packages/vitest/src/node/create.ts b/packages/vitest/src/node/create.ts
@@ -24,7 +24,7 @@ export async function createVitest(mode: VitestRunMode, options: UserConfig, vit
     logLevel: 'error',
     configFile: configPath,
     // this will make "mode": "test" | "benchmark" inside defineConfig
-    mode: options.mode || mode || process.env.NODE_ENV,
+    mode: options.mode || mode,
     plugins: await VitestPlugin(options, ctx),
   }
 

diff --git a/packages/vitest/src/node/pool.ts b/packages/vitest/src/node/pool.ts
@@ -75,7 +75,7 @@ export function createPool(ctx: Vitest): ProcessPool {
       env: {
         TEST: 'true',
         VITEST: 'true',
-        NODE_ENV: ctx.config.mode || 'test',
+        NODE_ENV: process.env.NODE_ENV || 'test',
         VITEST_MODE: ctx.config.watch ? 'WATCH' : 'RUN',
         ...process.env,
         ...ctx.config.env,

diff --git a/packages/vitest/src/node/workspace.ts b/packages/vitest/src/node/workspace.ts
@@ -41,8 +41,8 @@ export async function initializeProject(workspacePath: string | number, ctx: Vit
     root,
     logLevel: 'error',
     configFile,
-    // this will make "mode" = "test" inside defineConfig
-    mode: options.mode || ctx.config.mode || process.env.NODE_ENV,
+    // this will make "mode": "test" | "benchmark" inside defineConfig
+    mode: options.mode || ctx.config.mode,
     plugins: [
       ...options.plugins || [],
       WorkspaceVitestPlugin(project, { ...options, root, workspacePath }),