diff --git a/go/vt/sqlparser/comments_test.go b/go/vt/sqlparser/comments_test.go index 7dc0ba3511b..8ec7d4905fa 100644 --- a/go/vt/sqlparser/comments_test.go +++ b/go/vt/sqlparser/comments_test.go @@ -397,14 +397,21 @@ func TestIgnoreMaxPayloadSizeDirective(t *testing.T) { {"insert /*vt+ IGNORE_MAX_PAYLOAD_SIZE=1 */ into user(id) values (1), (2)", true}, {"insert into user(id) values (1), (2)", false}, {"update /*vt+ IGNORE_MAX_PAYLOAD_SIZE=1 */ users set name=1", true}, + {"update users set name=1", false}, {"select /*vt+ IGNORE_MAX_PAYLOAD_SIZE=1 */ * from users", true}, + {"select * from users", false}, {"delete /*vt+ IGNORE_MAX_PAYLOAD_SIZE=1 */ from users", true}, + {"delete from users", false}, + {"show /*vt+ IGNORE_MAX_PAYLOAD_SIZE=1 */ create table users", false}, + {"show create table users", false}, } for _, test := range testCases { - stmt, _ := Parse(test.query) - got := IgnoreMaxPayloadSizeDirective(stmt) - assert.Equalf(t, test.expected, got, fmt.Sprintf("IgnoreMaxPayloadSizeDirective(stmt) returned %v but expected %v", got, test.expected)) + t.Run(test.query, func(t *testing.T) { + stmt, _ := Parse(test.query) + got := IgnoreMaxPayloadSizeDirective(stmt) + assert.Equalf(t, test.expected, got, fmt.Sprintf("IgnoreMaxPayloadSizeDirective(stmt) returned %v but expected %v", got, test.expected)) + }) } }