From d6a5ee00d490a75fe61dda09c2d74a3a28842cb6 Mon Sep 17 00:00:00 2001 From: Jacques Grove Date: Mon, 27 Apr 2020 21:38:38 -0700 Subject: [PATCH] Replace Sprintf by string concat in normalizer, reduces vtgate CPU usage by 3-5% on QPS-heavy import benchmark. Signed-off-by: Jacques Grove --- go/vt/sqlparser/normalizer.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/go/vt/sqlparser/normalizer.go b/go/vt/sqlparser/normalizer.go index f715c8f4620..35c5aa97a20 100644 --- a/go/vt/sqlparser/normalizer.go +++ b/go/vt/sqlparser/normalizer.go @@ -17,7 +17,7 @@ limitations under the License. package sqlparser import ( - "fmt" + "strconv" "vitess.io/vitess/go/sqltypes" @@ -206,7 +206,7 @@ func (nz *normalizer) sqlToBindvar(node SQLNode) *querypb.BindVariable { func (nz *normalizer) newName() string { for { - newName := fmt.Sprintf("%s%d", nz.prefix, nz.counter) + newName := nz.prefix + strconv.Itoa(nz.counter) if _, ok := nz.reserved[newName]; !ok { nz.reserved[newName] = struct{}{} return newName