From 6c37b47cd0e8630f40acd0b7216341f6105ad842 Mon Sep 17 00:00:00 2001 From: Andres Taylor Date: Thu, 30 Aug 2018 15:39:06 +0200 Subject: [PATCH] Better error message when topology implementation is not found Signed-off-by: Andres Taylor --- go/vt/topo/errors.go | 3 +++ go/vt/topo/server.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/go/vt/topo/errors.go b/go/vt/topo/errors.go index f66d3b6465d..a0bf8ad8dde 100644 --- a/go/vt/topo/errors.go +++ b/go/vt/topo/errors.go @@ -31,6 +31,7 @@ const ( BadVersion PartialResult NoUpdateNeeded + NoImplementation ) // Error represents a topo error. @@ -59,6 +60,8 @@ func NewError(code ErrorCode, node string) error { message = fmt.Sprintf("partial result: %s", node) case NoUpdateNeeded: message = fmt.Sprintf("no update needed: %s", node) + case NoImplementation: + message = fmt.Sprintf("no such topology implementation %s", node) default: message = fmt.Sprintf("unknown code: %s", node) } diff --git a/go/vt/topo/server.go b/go/vt/topo/server.go index 4f4702e3ce3..e32e3d1835a 100644 --- a/go/vt/topo/server.go +++ b/go/vt/topo/server.go @@ -199,7 +199,7 @@ func NewWithFactory(factory Factory, serverAddress, root string) (*Server, error func OpenServer(implementation, serverAddress, root string) (*Server, error) { factory, ok := factories[implementation] if !ok { - return nil, NewError(NoNode, implementation) + return nil, NewError(NoImplementation, implementation) } return NewWithFactory(factory, serverAddress, root) }