diff --git a/.github/workflows/check_make_vtadmin_web_proto.yml b/.github/workflows/check_make_vtadmin_web_proto.yml index 5f3fd821893..dc60dd35d47 100644 --- a/.github/workflows/check_make_vtadmin_web_proto.yml +++ b/.github/workflows/check_make_vtadmin_web_proto.yml @@ -59,7 +59,7 @@ jobs: uses: actions/setup-node@v3 with: # node-version should match package.json - node-version: '16.19.0' + node-version: '18.16.0' - name: Install npm dependencies if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.proto_changes == 'true' diff --git a/.github/workflows/vtadmin_web_build.yml b/.github/workflows/vtadmin_web_build.yml index 441561447ee..4b67de1ea6d 100644 --- a/.github/workflows/vtadmin_web_build.yml +++ b/.github/workflows/vtadmin_web_build.yml @@ -42,7 +42,7 @@ jobs: if: steps.skip-workflow.outputs.skip-workflow == 'false' with: # node-version should match package.json - node-version: '16.19.0' + node-version: '18.16.0' - name: Install dependencies if: steps.skip-workflow.outputs.skip-workflow == 'false' diff --git a/.github/workflows/vtadmin_web_lint.yml b/.github/workflows/vtadmin_web_lint.yml index fe88053ff5a..055e1934fb0 100644 --- a/.github/workflows/vtadmin_web_lint.yml +++ b/.github/workflows/vtadmin_web_lint.yml @@ -42,7 +42,7 @@ jobs: if: steps.skip-workflow.outputs.skip-workflow == 'false' with: # node-version should match package.json - node-version: '16.19.0' + node-version: '18.16.0' - name: Install dependencies if: steps.skip-workflow.outputs.skip-workflow == 'false' diff --git a/.github/workflows/vtadmin_web_unit_tests.yml b/.github/workflows/vtadmin_web_unit_tests.yml index cab00c8dea9..5c831b35666 100644 --- a/.github/workflows/vtadmin_web_unit_tests.yml +++ b/.github/workflows/vtadmin_web_unit_tests.yml @@ -42,7 +42,7 @@ jobs: if: steps.skip-workflow.outputs.skip-workflow == 'false' with: # node-version should match package.json - node-version: '16.19.0' + node-version: '18.16.0' - name: Install dependencies if: steps.skip-workflow.outputs.skip-workflow == 'false' diff --git a/changelog/18.0/18.0.0/summary.md b/changelog/18.0/18.0.0/summary.md index e1270eaf797..2171e02b31c 100644 --- a/changelog/18.0/18.0.0/summary.md +++ b/changelog/18.0/18.0.0/summary.md @@ -6,6 +6,8 @@ - **[Breaking Changes](#breaking-changes)** - **[New command line flags and behavior](#new-flag)** - [VTOrc flag `--allow-emergency-reparent`](#new-flag-toggle-ers) + - **[VTAdmin](#vtadmin)** + - [Updated to node v18.16.0](#update-node) - **[Deprecations and Deletions](#deprecations-and-deletions)** - [Deleted `k8stopo`](#deleted-k8stopo) - [Deleted `vtgr`](#deleted-vtgr) @@ -22,6 +24,12 @@ VTOrc has a new flag `--allow-emergency-reparent` that allows the users to toggl The users that want VTOrc to fix the replication issues, but don't want it to run any reparents should start using this flag. By default, VTOrc will be able to run `EmergencyReparentShard`. The users must specify the flag to `false` to change the behaviour. +### VTAdmin +#### vtadmin-web updated to node v18.16.0 (LTS) + +Building vtadmin-web now requires node >= v18.16.0 (LTS). Breaking changes from v16 to v18 are listed +in https://nodejs.org/en/blog/release/v18.0.0, but none apply to VTAdmin. Full details on v18.16.0 are listed here https://nodejs.org/en/blog/release/v18.16.0. + ### Deprecations and Deletions #### Deleted `k8stopo` diff --git a/examples/common/scripts/vtadmin-up.sh b/examples/common/scripts/vtadmin-up.sh index 387ba439fb0..fd4cd6e7f0c 100755 --- a/examples/common/scripts/vtadmin-up.sh +++ b/examples/common/scripts/vtadmin-up.sh @@ -53,7 +53,7 @@ if [[ -z ${NVM_DIR} ]]; then fi if [[ -z ${NODE_VERSION} ]]; then - export NODE_VERSION="16" + export NODE_VERSION="18.16.0" fi output "\nInstalling nvm...\n" diff --git a/web/vtadmin/README.md b/web/vtadmin/README.md index 3b72d0eab23..843c0711de2 100644 --- a/web/vtadmin/README.md +++ b/web/vtadmin/README.md @@ -2,9 +2,8 @@ ## Prerequisites -- [node](https://nodejs.org) >= 16.19.0 LTS - - _Note_: If you are using Node >= 17.x.y, you may see errors like `Error: error:0308010C:digital envelope routines::unsupported` when running `npm run build`. This is due to node dropping support for older versions of `openssl`. A workaround was added in [nodejs/node#40455](https://github.com/nodejs/node/issues/40455), allowing you to `export NODE_OPTIONS="--openssl-legacy-provider"` before running `npm run build`. -- npm >= 8.1.0 (comes with node) +- [node](https://nodejs.org) >= 18.16.0 LTS +- npm >= 9.7.1 (comes with node) ## Available scripts diff --git a/web/vtadmin/package-lock.json b/web/vtadmin/package-lock.json index bbaf86ab494..baf7fce6e8c 100644 --- a/web/vtadmin/package-lock.json +++ b/web/vtadmin/package-lock.json @@ -67,8 +67,8 @@ "vitest": "^0.29.8" }, "engines": { - "node": ">=16.19.0", - "npm": ">=8.1.0" + "node": ">=18.16.0", + "npm": ">=9.5.1" } }, "node_modules/@adobe/css-tools": { diff --git a/web/vtadmin/package.json b/web/vtadmin/package.json index 71af6572b87..33a2f87297e 100644 --- a/web/vtadmin/package.json +++ b/web/vtadmin/package.json @@ -3,8 +3,8 @@ "version": "0.1.0", "private": true, "engines": { - "node": ">=16.19.0", - "npm": ">=8.1.0" + "node": ">=18.16.0", + "npm": ">=9.5.1" }, "dependencies": { "@bugsnag/js": "^7.20.0",