diff --git a/.github/workflows/unit_race.yml b/.github/workflows/unit_race.yml index 55f75ede106..95217bfec4d 100644 --- a/.github/workflows/unit_race.yml +++ b/.github/workflows/unit_race.yml @@ -93,6 +93,6 @@ jobs: - name: unit_race if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.unit_tests == 'true' - timeout-minutes: 30 + timeout-minutes: 45 run: | eatmydata -- make unit_test_race diff --git a/go/mysql/fakesqldb/server.go b/go/mysql/fakesqldb/server.go index b5952d90ed0..7bd38e0665f 100644 --- a/go/mysql/fakesqldb/server.go +++ b/go/mysql/fakesqldb/server.go @@ -616,11 +616,15 @@ func (db *DB) GetQueryCalledNum(query string) int { // QueryLog returns the query log in a semicomma separated string func (db *DB) QueryLog() string { + db.mu.Lock() + defer db.mu.Unlock() return strings.Join(db.querylog, ";") } // ResetQueryLog resets the query log func (db *DB) ResetQueryLog() { + db.mu.Lock() + defer db.mu.Unlock() db.querylog = nil } diff --git a/go/vt/vtctl/grpcvtctldserver/server.go b/go/vt/vtctl/grpcvtctldserver/server.go index 49489a7ae9a..0351ed2f48f 100644 --- a/go/vt/vtctl/grpcvtctldserver/server.go +++ b/go/vt/vtctl/grpcvtctldserver/server.go @@ -4255,7 +4255,9 @@ func (s *VtctldServer) ValidateVersionShard(ctx context.Context, req *vtctldatap } wg.Add(1) - go s.diffVersion(ctx, primaryVersion.Version, shard.PrimaryAlias, alias, &wg, &er) + go func(alias *topodatapb.TabletAlias) { + s.diffVersion(ctx, primaryVersion.Version, shard.PrimaryAlias, alias, &wg, &er) + }(alias) } wg.Wait() diff --git a/go/vt/vtctl/grpcvtctldserver/server_test.go b/go/vt/vtctl/grpcvtctldserver/server_test.go index a482ad80e02..48b53c53c05 100644 --- a/go/vt/vtctl/grpcvtctldserver/server_test.go +++ b/go/vt/vtctl/grpcvtctldserver/server_test.go @@ -2707,7 +2707,7 @@ func TestDeleteShards(t *testing.T) { defer func() { topofactory.SetError(nil) - actualShards := []*vtctldatapb.Shard{} + var actualShards []*vtctldatapb.Shard keyspaces, err := ts.GetKeyspaces(ctx) require.NoError(t, err, "cannot get keyspace names to check remaining shards")