From f03f2de4e086c67d2621b5a197425446baa512a9 Mon Sep 17 00:00:00 2001 From: bluwy Date: Mon, 27 Apr 2026 23:39:10 +0800 Subject: [PATCH 1/2] refactor: show direct path type in bad character warning Co-authored-by: Copilot --- packages/vite/src/node/config.ts | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index cbbeefab65a698..5113a0f8a1020a 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -1016,6 +1016,7 @@ export type ResolveFn = ( */ function checkBadCharactersInPath( name: string, + type: 'directory' | 'file', path: string, logger: Logger, ): void { @@ -1039,7 +1040,7 @@ function checkBadCharactersInPath( colors.yellow( `${name} contains the ${charString} ${inflectedChars} (${colors.cyan( path, - )}), which may not work when running Vite. Consider renaming the directory / file to remove the characters.`, + )}), which may not work when running Vite. Consider renaming the ${type} without the characters.`, ), ) } @@ -1487,7 +1488,12 @@ export async function resolveConfig( config.root ? path.resolve(config.root) : process.cwd(), ) - checkBadCharactersInPath('The project root', resolvedRoot, logger) + checkBadCharactersInPath( + 'The project root', + 'directory', + resolvedRoot, + logger, + ) const configEnvironmentsClient = config.environments!.client! configEnvironmentsClient.dev ??= {} @@ -2283,7 +2289,7 @@ export async function loadConfigFromFile( } } catch (e) { const logger = createLogger(logLevel, { customLogger }) - checkBadCharactersInPath('The config path', resolvedPath, logger) + checkBadCharactersInPath('The config path', 'file', resolvedPath, logger) logger.error(colors.red(`failed to load config from ${resolvedPath}`), { error: e, }) From a69f3a9e9ede82bfb8b94267f197572d7b1f4a41 Mon Sep 17 00:00:00 2001 From: bluwy Date: Mon, 27 Apr 2026 23:46:42 +0800 Subject: [PATCH 2/2] chore: fix test Co-authored-by: Copilot --- packages/vite/src/node/__tests__/config.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vite/src/node/__tests__/config.spec.ts b/packages/vite/src/node/__tests__/config.spec.ts index 85737eafe3f8fb..98e61f0c4142a9 100644 --- a/packages/vite/src/node/__tests__/config.spec.ts +++ b/packages/vite/src/node/__tests__/config.spec.ts @@ -915,7 +915,7 @@ describe('resolveConfig', () => { const logger = createLogger('info') logger.warn = (str) => { expect(str).to.include( - 'Consider renaming the directory / file to remove the characters', + 'Consider renaming the directory without the characters', ) }