fix(legacy): workaround safari 15 error caching bug#22028
Merged
sapphi-red merged 2 commits intoMar 26, 2026
Merged
Conversation
sapphi-red
added
plugin: legacy
p4-important
sapphi-red
deleted the
fix/legacy-workaround-safari-15-error-caching-bug
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari 15.x and below seems to have a bug that an error thrown in the module is only triggered once (probably related to WebKit/WebKit@92ba524). That makes the legacy browser detection to break.
To workaround that bug, this PR makes each detection module to be unique.
I tested this code on Safari 15.6.
fixes #22008