Skip to content

fix(optimizer): skip rolldownCjsExternalPlugin for platform: neutral #21452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 1 commit into from
Jan 22, 2026
Merged

fix(optimizer): skip rolldownCjsExternalPlugin for platform: neutral #21452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/vite/src/node/optimizer/rolldownDepPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,10 +315,14 @@ export function rolldownCjsExternalPlugin(
if (platform === 'node') {
return undefined
}
// Skip this plugin for `platform: 'neutral'` as we are not sure whether `require` is available
if (platform === 'neutral') {
return undefined
}

// Apply this plugin for `platform: 'browser'` as `require` is not available in browser and
// converting to `import` would be necessary to make the code work
platform satisfies 'browser' | 'neutral'
platform satisfies 'browser'

const filter = new RegExp(externals.map(matchesEntireLine).join('|'))

Expand Down
Loading