Skip to content

fix(worker): handle new Worker(..., new URL(import.meta.url)) with trailing comma #21325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 3 commits into from
Dec 22, 2025
+33 −1
Merged

fix(worker): handle new Worker(..., new URL(import.meta.url)) with trailing comma #21325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4804226
Initial plan
Copilot Dec 22, 2025
2966f54
Fix multi-line new URL parsing with trailing comma
Copilot Dec 22, 2025
80808a9
Simplify test case to use ./worker.js for consistency
Copilot Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions packages/vite/src/node/__tests__/plugins/workerImportMetaUrl.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,4 +221,36 @@ new Worker(
`"repro(new Worker(new URL(/* @vite-ignore */ "/worker?worker_file&type=classic", '' + import.meta.url)), { type: "module" })"`,
)
})

test('with multi-line new URL and trailing comma', async () => {
expect(
await transform(`new Worker(
new URL(
"./worker.js",
import.meta.url,
)
)`),
).toMatchInlineSnapshot(`
"new Worker(
new URL(/* @vite-ignore */ "/worker.js?worker_file&type=classic", '' + import.meta.url)
)"
`)
})

test('with multi-line new URL, trailing comma, and worker options', async () => {
expect(
await transform(`const worker = new Worker(
new URL(
"./worker.js",
import.meta.url,
),
{ type: "module" },
)`),
).toMatchInlineSnapshot(`
"const worker = new Worker(
new URL(/* @vite-ignore */ "/worker.js?worker_file&type=module", '' + import.meta.url),
{ type: "module" },
)"
`)
})
})
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/workerImportMetaUrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ export function workerImportMetaUrlPlugin(config: ResolvedConfig): Plugin {
let s: MagicString | undefined
const cleanString = stripLiteral(code)
const workerImportMetaUrlRE =
/\bnew\s+(?:Worker|SharedWorker)\s*\(\s*(new\s+URL\s*\(\s*('[^']+'|"[^"]+"|`[^`]+`)\s*,\s*import\.meta\.url\s*\))/dg
/\bnew\s+(?:Worker|SharedWorker)\s*\(\s*(new\s+URL\s*\(\s*('[^']+'|"[^"]+"|`[^`]+`)\s*,\s*import\.meta\.url\s*(?:,\s*)?\))/dg

let match: RegExpExecArray | null
while ((match = workerImportMetaUrlRE.exec(cleanString))) {
Expand Down
Loading