Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// @ts-check
import { builtinModules, createRequire } from 'node:module'
import { createRequire } from 'node:module'
import eslint from '@eslint/js'
import pluginN from 'eslint-plugin-n'
import pluginImportX from 'eslint-plugin-import-x'
Expand Down Expand Up @@ -113,6 +113,7 @@ export default tseslint.config(
allowModules: ['vite'],
},
],
'n/prefer-node-protocol': 'error',

'@typescript-eslint/ban-ts-comment': 'error',
'@typescript-eslint/no-unsafe-function-type': 'off',
Expand Down Expand Up @@ -157,10 +158,6 @@ export default tseslint.config(
'@typescript-eslint/prefer-for-of': 'off',
'@typescript-eslint/prefer-function-type': 'off',

'import-x/no-nodejs-modules': [
'error',
{ allow: builtinModules.map((mod) => `node:${mod}`) },
],
'import-x/no-duplicates': 'error',
'import-x/order': [
'error',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export { existsSync } from 'node:fs'
// eslint-disable-next-line import-x/no-nodejs-modules -- testing that importing without node prefix works
// eslint-disable-next-line n/prefer-node-protocol -- testing that importing without node prefix works
export { readdirSync } from 'fs'
2 changes: 1 addition & 1 deletion playground/cli-module/vite.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// eslint-disable-next-line import-x/no-nodejs-modules
// eslint-disable-next-line n/prefer-node-protocol
import { URL } from 'url'
import { defineConfig } from 'vite'

Expand Down
2 changes: 1 addition & 1 deletion playground/object-hooks/vite.config.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable import-x/no-nodejs-modules */
/* eslint-disable n/prefer-node-protocol */
import assert from 'assert'
import { defineConfig } from 'vite'

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

// eslint-disable-next-line import-x/no-nodejs-modules
// eslint-disable-next-line n/prefer-node-protocol
const events = require('events')

module.exports = 'foo' in events ? 'pong' : ''
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// `stream` is used as the package name for `@vitejs/test-dep-esm-dummy-node-builtin` so that it is treated like a Node builtin
// eslint-disable-next-line import-x/no-nodejs-modules
// eslint-disable-next-line n/prefer-node-protocol
const externalDummyNodeBuiltin = require('stream')
const external = require('@vitejs/test-dep-esm-external')
// eslint-disable-next-line no-prototype-builtins
Expand Down
4 changes: 2 additions & 2 deletions playground/optimize-deps/dep-with-builtin-module-cjs/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// no node: protocol intentionally
// eslint-disable-next-line import-x/no-nodejs-modules
// eslint-disable-next-line n/prefer-node-protocol
const fs = require('fs')
// eslint-disable-next-line import-x/no-nodejs-modules
// eslint-disable-next-line n/prefer-node-protocol
const path = require('path')

// NOTE: require destructure would error immediately because of how esbuild
Expand Down
4 changes: 2 additions & 2 deletions playground/optimize-deps/dep-with-builtin-module-esm/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// no node: protocol intentionally
// eslint-disable-next-line import-x/no-nodejs-modules
// eslint-disable-next-line n/prefer-node-protocol
import { readFileSync } from 'fs'
// eslint-disable-next-line import-x/no-nodejs-modules
// eslint-disable-next-line n/prefer-node-protocol
import path from 'path'

// access from named import
Expand Down