From 4795c4dc6a7ae721d2c0538c404105b427777b08 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Tue, 13 May 2025 09:33:59 +0900 Subject: [PATCH 1/3] chore: deprecate `ResolvedConfig.createResolver` in favor of `createIdResolver` --- packages/vite/src/node/config.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index bca15149ec57cd..ec0cf2104871e4 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -606,6 +606,15 @@ export interface ResolvedConfig ssr: ResolvedSSROptions assetsInclude: (file: string) => boolean logger: Logger + /** + * createResolver is deprecated. It only works for the client and ssr + * environments. The `aliasOnly` option is also not being used any more + * Plugins should move to createIdResolver(environment) instead. + * create an internal resolver to be used in special scenarios, e.g. + * optimizer & handling css @imports + * + * @deprecated Use `createIdResolver(environment)` instead. + */ createResolver: (options?: Partial) => ResolveFn optimizeDeps: DepOptimizationOptions /** @internal */ From f36ba4115c94d2ad7ac5077123b74dac33c40c62 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Tue, 13 May 2025 09:43:54 +0900 Subject: [PATCH 2/3] chore: tweak --- packages/vite/src/node/config.ts | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index ec0cf2104871e4..4b579c9dc5906a 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -609,11 +609,11 @@ export interface ResolvedConfig /** * createResolver is deprecated. It only works for the client and ssr * environments. The `aliasOnly` option is also not being used any more - * Plugins should move to createIdResolver(environment) instead. + * Plugins should move to createIdResolver(environment.config) instead. * create an internal resolver to be used in special scenarios, e.g. * optimizer & handling css @imports * - * @deprecated Use `createIdResolver(environment)` instead. + * @deprecated Use `createIdResolver` instead. */ createResolver: (options?: Partial) => ResolveFn optimizeDeps: DepOptimizationOptions @@ -1523,13 +1523,6 @@ export async function resolveConfig( getSortedPlugins: undefined!, getSortedPluginHooks: undefined!, - /** - * createResolver is deprecated. It only works for the client and ssr - * environments. The `aliasOnly` option is also not being used any more - * Plugins should move to createIdResolver(environment) instead. - * create an internal resolver to be used in special scenarios, e.g. - * optimizer & handling css @imports - */ createResolver(options) { const resolve = createIdResolver(this, options) const clientEnvironment = new PartialEnvironment('client', this) From 76f5f39d227b5d4a96f62e88c9109886ae120304 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Wed, 14 May 2025 08:25:45 +0900 Subject: [PATCH 3/3] docs: suggestion Co-authored-by: Bjorn Lu --- packages/vite/src/node/config.ts | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index 4b579c9dc5906a..07090ca14dd7db 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -607,13 +607,14 @@ export interface ResolvedConfig assetsInclude: (file: string) => boolean logger: Logger /** - * createResolver is deprecated. It only works for the client and ssr - * environments. The `aliasOnly` option is also not being used any more - * Plugins should move to createIdResolver(environment.config) instead. - * create an internal resolver to be used in special scenarios, e.g. - * optimizer & handling css @imports + * Create an internal resolver to be used in special scenarios, e.g. + * optimizer & handling css `@imports`. * - * @deprecated Use `createIdResolver` instead. + * This API is deprecated. It only works for the client and ssr + * environments. The `aliasOnly` option is also not being used anymore. + * Plugins should move to `createIdResolver(environment.config)` instead. + * + * @deprecated Use `createIdResolver` from `vite` instead. */ createResolver: (options?: Partial) => ResolveFn optimizeDeps: DepOptimizationOptions