Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): exclude config.assetsInclude empty array #10941

Merged
merged 1 commit into from
Nov 15, 2022
Merged

fix(config): exclude config.assetsInclude empty array #10941

merged 1 commit into from
Nov 15, 2022

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Nov 15, 2022

Description

fixes #10926

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev enabled auto-merge (squash) November 15, 2022 15:45
@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Nov 15, 2022
@patak-dev patak-dev merged commit 18c71dc into vitejs:main Nov 15, 2022
@bluwy bluwy mentioned this pull request Nov 16, 2022
Merged
bluwy pushed a commit that referenced this pull request Nov 29, 2022
@sun0day @bluwy
fix(config): exclude config.assetsInclude empty array (#10941)
7f85d87 
fixes #10926
@bluwy bluwy mentioned this pull request Nov 29, 2022
Merged
patak-dev pushed a commit that referenced this pull request Nov 30, 2022
@bluwy @sun0day @jquense
chore: cherry pick v4 bug fix to v3 (#11110)
c93a526 
* fix(config): exclude config.assetsInclude empty array (#10941)

fixes #10926

* feat(css): upgrade postcss-modules (#10987)

* fix(mpa): support mpa fallback (#10985)

fixes #10966

* fix: export preprocessCSS in CJS (#11067)

* chore: update license

Co-authored-by: sun0day <[email protected]>
Co-authored-by: Jason Quense <[email protected]>
Co-authored-by: sun0day <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assetsInclude=[] in vite config causes extra file generation and path complications
2 participants
@sun0day @patak-dev