-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support import.meta.hot.invalidate #10244
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c211824
feat: support `import.meta.hot.invalidate`
aleclarson 002bd60
fix: enable `hot.invalidate` for self-accepting modules only
aleclarson 6c71e79
fix: ignore `hot.invalidate` call if hmr timestamp is zero
aleclarson 8b9cb67
fix: use `lastHMRTimestamp` in `hot.invalidate` handler
aleclarson 295c6de
chore: remove unused import
IanVS d0eb297
chore: format
IanVS 68fe6ff
feat: notify listeners to invalidation changes
IanVS 83cb7cc
test: add test for invalidation
IanVS 970aa77
docs: update documentation for hot.invalidate
IanVS 93608ea
Update packages/vite/src/node/server/index.ts
aleclarson 6330948
Update playground/hmr/invalidation/child.js
IanVS 898e09e
chore: remove unused import
IanVS a21886d
Update docs/guide/api-hmr.md
IanVS d147d6b
types: add type for vite:invalidate payload
IanVS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
if (import.meta.hot) { | ||
// Need to accept, to register a callback for HMR | ||
import.meta.hot.accept(() => { | ||
// Trigger HMR in importers | ||
import.meta.hot.invalidate() | ||
}) | ||
} | ||
|
||
export const value = 'child' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { value } from './child' | ||
|
||
if (import.meta.hot) { | ||
import.meta.hot.accept() | ||
} | ||
|
||
console.log('(invalidation) parent is executing') | ||
|
||
document.querySelector('.invalidation').innerHTML = value |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sapphi is talking about this client-side event, I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this client event is even worth adding? What's the use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the use case for all of these is to help debug HMR problems and also to confirm they're working as expected in tests.
If I add the type to the HMRPayload union, then I'd need to handle it where I pointed out because of the exhaustive switch statement. I could create a separate type that's not included in that union, but it would be different from the others. But, I guess it is different, so maybe that's fine.
I'm also happy to remove the notifyListeners if that's preferred.