Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tidy up eslint config #9468

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 31, 2022

Description

This PR changes the strategy of configuring what file to run eslint.

Before: Use eslint foo to run lint on limited files and configure ignore/rules with .eslintignore/overrides.
After: Use eslint . to run lint on all files by default and configure ignore/rules with .eslintignore/overrides.

By using eslint ., it will be aligned with other eslint integrations such as eslint VSCode extension.

close #7769 (because after this PR, if pnpm lint does not output any errors, it means VSCode extension won't have any errors)

requires eslint-types/eslint-define-config#120 to be released to fix the type error in .eslintrc.cjs. updated

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Jul 31, 2022
@@ -107,6 +95,30 @@ module.exports = defineConfig({
]
},
overrides: [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorted with packages -> playgrounds -> file extensions

@sapphi-red sapphi-red marked this pull request as ready for review July 31, 2022 14:42
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@sapphi-red sapphi-red merged commit f4addcf into vitejs:main Aug 1, 2022
@sapphi-red sapphi-red deleted the chore/eslint-dot branch August 1, 2022 05:39
@dammy001
Copy link

dammy001 commented Aug 1, 2022

💪🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants