Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-legacy): disable babel.compact when minify is disabled #8244

Merged
merged 1 commit into from
May 20, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented May 20, 2022

Description

compact was set to true always.
This PR changes it to false when build.minify is false.

It might be slightly faster when compact is true than false. So ones who is setting build.minify to false with intention to reduce build time will get a negative effect from this change.

I tested this by setting build.minify to false at playground/legacy/vite.config.js.

close #8180

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added plugin: legacy p3-minor-bug An edge case that only affects very specific usage (priority) labels May 20, 2022
@patak-dev patak-dev merged commit 742188c into vitejs:main May 20, 2022
@sapphi-red sapphi-red deleted the fix/babel-compact-minify branch May 21, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) plugin: legacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

legacy-plugin forces minify (still)
2 participants