chore: cleanup now that we've dropped Node 12 #8239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Shinigami92
previously approved these changes
May 20, 2022
sapphi-red
previously approved these changes
May 20, 2022
|
Awesome, let's merge this one in a few days, after we do another 2.9 patch. |
ydcjeff
previously approved these changes
May 20, 2022
patak-dev
dismissed stale reviews from ydcjeff, sapphi-red, and Shinigami92
via
6a192be
patak-dev
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drop Node 12 code
Additional context
Discovered here: https://github.com/vitejs/vite/pull/8235/files#r877715524
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).