Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): use esno to replace ts-node #8152

Merged
merged 10 commits into from
May 13, 2022
Merged

chore(deps): use esno to replace ts-node #8152

merged 10 commits into from
May 13, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented May 13, 2022

No description provided.

aladdin-add
aladdin-add previously approved these changes May 13, 2022
View reviewed changes
@sapphi-red
Copy link
Member

You might want to remove ts-node from devDeps and renovate.json5.

@aladdin-add
Copy link

need to remove:

@antfu antfu changed the title chore: use esno to replace ts-node chore(deps): use esno to replace ts-node May 13, 2022
@antfu antfu merged commit 2363bd3 into main May 13, 2022
@antfu antfu deleted the chore/esno branch May 13, 2022 07:05
@sapphi-red
Copy link
Member

Looks like this error is happening frequently.
Error: ENOENT: no such file or directory, open '/tmp/esbuild-kit/16524-74c8df34597ce71639eb861c859a7174e79e54b9'
https://github.com/vitejs/vite/actions/runs/2317845205/attempts/1
https://github.com/vitejs/vite/actions/runs/2317959186

antfu added a commit that referenced this pull request May 13, 2022
@antfu
Revert "chore(deps): use esno to replace ts-node (#8152)"
c185626 
This reverts commit 2363bd3.
@antfu antfu mentioned this pull request May 13, 2022
Merged
antfu added a commit that referenced this pull request May 13, 2022
@antfu
chore: revert #8152 (#8161)
85b8b55 
This reverts commit 2363bd3.
@antfu antfu restored the chore/esno branch May 13, 2022 07:42
@antfu
Copy link
Member Author

antfu commented May 13, 2022 •
edited
Loading

Reverted for now. /cc @privatenumber any clue on the cause of this?

@antfu antfu mentioned this pull request May 13, 2022
Merged
@privatenumber
Copy link
Contributor

Fixed in esbuild-kit/core-utils#1

@IanVS
Copy link
Contributor

IanVS commented May 25, 2022

Hi, any chance someone could explain the reason for this change, or link to an issue/discussion where this was talked about? I always find it very useful when the context/reasoning behind a change are included in the PR. I'm not saying the change shouldn't have been made, I'm just trying to learn / follow along.

haoqunjiang pushed a commit to vitejs/vite-plugin-vue2-jsx that referenced this pull request Jul 8, 2022
@antfu
chore: revert vitejs/vite#8152 (#8161)
5b66f3a 
This reverts commit 5901ec4.
patak-dev pushed a commit to vitejs/vite-plugin-react that referenced this pull request Dec 2, 2022
@antfu
chore: revert vitejs/vite#8152 (#8161)
d63623c 
This reverts commit f32313a.
patak-dev pushed a commit to vitejs/vite-plugin-vue that referenced this pull request Dec 2, 2022
@antfu
chore: revert vitejs/vite#8152 (#8161)
be1d42c 
This reverts commit 612a1b6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@bluwy bluwy bluwy approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@antfu @sapphi-red @aladdin-add @privatenumber @IanVS @bluwy