Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: remove node v12 support #7833

Merged
merged 3 commits into from
May 5, 2022
Merged

build!: remove node v12 support #7833

merged 3 commits into from
May 5, 2022

Conversation

Shinigami92
Copy link
Member

Description

Fully remove support for node v12

Additional context

According to https://kangax.github.io/compat-table/es2016plus/#node14_6 I switched also to at least v14.6.0
If I'm correct, we also can target ES2020 from now on 🎉

For upgrade to node v18 see #7812


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 self-assigned this Apr 20, 2022
@Shinigami92 Shinigami92 added this to the 3.0 milestone Apr 20, 2022
@Shinigami92 Shinigami92 changed the title build: remove node v12 support build!: remove node v12 support Apr 20, 2022
@Shinigami92 Shinigami92 mentioned this pull request Apr 20, 2022
9 tasks
@Shinigami92 Shinigami92 marked this pull request as ready for review April 20, 2022 12:32
ydcjeff
ydcjeff previously approved these changes Apr 20, 2022
@Shinigami92 Shinigami92 dismissed stale reviews from ghost and ydcjeff via b84ccd5 April 23, 2022 10:53
@ydcjeff
Copy link
Contributor

ydcjeff commented Apr 23, 2022

This PR will fix #5843 and #5841

@bluwy bluwy mentioned this pull request Apr 25, 2022
9 tasks
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to update the versions in the docs like in #5843 (here and here)

@bluwy bluwy linked an issue Apr 25, 2022 that may be closed by this pull request
4 tasks
@Shinigami92
Copy link
Member Author

We may also want to update the versions in the docs like in #5843 (here and here)

done

@Shinigami92 Shinigami92 requested a review from bluwy April 25, 2022 11:06
@sapphi-red
Copy link
Member

Maybe it is out of scope of this PR, but you might forgot to change build settings?
Examples

@Shinigami92
Copy link
Member Author

Maybe it is out of scope of this PR, but you might forgot to change build settings? Examples

I think we should do this in a separate PR 🤔

@patak-dev patak-dev merged commit eeac2d2 into main May 5, 2022
@patak-dev patak-dev deleted the remove-node-12-support branch May 5, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Node v12 support
6 participants