mime type for .ico file is undefined

[otakustay]

Describe the bug

mrmime doesn't support mime type lookup for .ico files, it returns undefined.

Run vite build && cat dist/index.html in reproduction, we can see a data:undefined/base64, string.

Given that .ico is a widely used format for favicons, how about we hard coding a mime type for it in fileToBuiltUrl function?

Reproduction

https://stackblitz.com/edit/vitejs-vite-7ogktc?file=index.html&terminal=dev

System Info

System:
    OS: macOS 12.1
    CPU: (8) arm64 Apple M1
    Memory: 86.78 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.0 - /var/folders/9v/sx18bwn925b3f2rp2jfg952w0000gn/T/fnm_multishells/81962_1645781288344/bin/node
    Yarn: 1.22.15 - /var/folders/9v/sx18bwn925b3f2rp2jfg952w0000gn/T/fnm_multishells/81962_1645781288344/bin/yarn
    npm: 8.3.0 - /var/folders/9v/sx18bwn925b3f2rp2jfg952w0000gn/T/fnm_multishells/81962_1645781288344/bin/npm
  Browsers:
    Chrome: 98.0.4758.109
    Safari: 15.2
  npmPackages:
    @vitejs/plugin-react: ^1.0.7 => 1.2.0
    vite: ^2.8.0 => 2.8.4

Used Package Manager

yarn

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[bluwy]

Related lukeed/mrmime#3

[poyoho]

emmm...

[otakustay]

It's safe when either the file is large enough to be extract as a separate asset, or it is not an .ico file

[poyoho]

None of the repos you provided have .ico file

[otakustay]

Sorry it seems I failed to save, I have edited it to https://stackblitz.com/edit/vitejs-vite-7ogktc?file=index.html&terminal=dev

[poyoho]

yes I see :p