Cannot pass an npm dependency as an entrypoint to build

[matthewp]

Describe the bug

If you attempt to pass an npm dependency to vite.build's rollupOptions.input you will get an error like this:

Could not resolve entry module (packages/astro/test/fixtures/static-build-frameworks/@astrojs/renderer-lit/client-shim.js).

This is a regression caused here: https://github.com/vitejs/vite/pull/5601/files#diff-aa53520bfd53e6c24220c44494457cc66370fd2bee513c15f9be7eb537a363e7R272-R286

It assumes that all entrypoints are files within the project root and not npm package dependencies.

Reproduction

https://stackblitz.com/edit/vitejs-vite-pcuytf?file=build.mjs

System Info

System:
    OS: macOS 12.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 178.72 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.17.0 - ~/.volta/tools/image/node/14.17.0/bin/node
    Yarn: 1.22.10 - ~/.volta/tools/image/yarn/1.22.10/bin/yarn
    npm: 7.11.2 - ~/.volta/tools/image/npm/7.11.2/bin/npm
  Browsers:
    Chrome: 97.0.4692.71
    Firefox: 96.0
    Safari: 15.2

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[natemoo-re]

For context, Astro's build command needs to be able to pass NPM dependencies as Rollup inputs. This allows us to emit code that isn't referenced directly in src/ files but is generated by our renderers (which are, of course, NPM dependencies configured by the user.)

If this is intentional and there's another approach we should be using, please let us know. This is currently blocking our upgrade to [email protected].

[sibbng]

For context, Astro's build command needs to be able to pass NPM dependencies as Rollup inputs. This allows us to emit code that isn't referenced directly in src/ files but is generated by our renderers (which are, of course, NPM dependencies configured by the user.)

If this is intentional and there's another approach we should be using, please let us know. This is currently blocking our upgrade to [email protected].

I didn't know rollup supports packages as input target. For now you could use require.resolve:
https://stackblitz.com/edit/vitejs-vite-pacpzp?file=build.mjs

In this case we could check the existence of entry point and fallback to original value if it's not exist.

[patak-dev]

@sibbng the reproduction from @matthewp works fine in rollup, and I think it should also work in Vite. We shouldn't force users to use require.resolve in their configs, and also there is no way to support virtual entry points (that are resolved by the plugin pipeline). See https://rollupjs.org/guide/en/#a-simple-example

[sibbng]

@patak-dev I'm not saying this doesn't need to be fixed 😀

In this case we could check the existence of entry point and fallback to original value if it's not exist.

[patak-dev]

I think we should revert and find a very good reason to change the default way rollup input works. Reviewing the issue where we change this, I think we didn't justify the change enough. The linked unocss issue could have been resolved by resolving in the config, no?

[sibbng]

I think we should revert and find a very good reason to change the default way rollup input works. Reviewing the issue where we change this, I think we didn't justify the change enough. The linked unocss issue could have been resolved by resolving in the config, no?

Ok, I look back the issue in unocss. Error comes from rollup-plugin-dynamic-import-variables. Probably the source of problem is here. I'm ok with the revert.