Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-react): avoid mangling the sourcemaps of virtual modules #5421

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

aleclarson
Copy link
Member

Previously, the sources array within a virtual module‘s sourcemap would contain the basename (ie: the characters after the last /) rather than the entire id string, which would trigger a "Sourcemap points to missing source files" warning for each virtual module.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Previously, the `sources` array within a virtual module‘s sourcemap would contain the basename (characters after the last "/") rather than the entire `id` string, which would trigger a "Sourcemap points to missing source files" warning for each virtual module.
@aleclarson aleclarson added p3-minor-bug An edge case that only affects very specific usage (priority) plugin: react labels Oct 25, 2021
@antfu antfu merged commit 8556ffe into vitejs:main Oct 26, 2021
@aleclarson aleclarson deleted the fix/react-3 branch February 25, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants