Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pnpm create-vite command documentation #4902

Merged
merged 2 commits into from
Sep 12, 2021
Merged

fix: pnpm create-vite command documentation #4902

merged 2 commits into from
Sep 12, 2021

Conversation

tropicalraisel
Copy link
Contributor

pnpx is deprecated: https://pnpm.io/pnpx-cli

Use pnpm dlx instead. 🌴

Description

Fixes deprecated documentation.

Additional context

N/A

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@tropicalraisel tropicalraisel changed the title Fixed pnpm create-vite command documentation fix: pnpm create-vite command documentation Sep 10, 2021
Shinigami92
Shinigami92 previously approved these changes Sep 11, 2021
View reviewed changes
patak-dev
patak-dev previously approved these changes Sep 11, 2021
View reviewed changes
@patak-dev
Copy link
Member

Thanks @tropicalraisel, there are other places in tge repo where npmx is used, would you like to also change those?

@tropicalraisel
Copy link
Contributor Author

@Shinigami92 @patak-js I've replaced the other pnpx entries 🌴

@underfin underfin merged commit 3392a8a into vitejs:main Sep 12, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@tropicalraisel @aleclarson
fix: pnpm create-vite command documentation (vitejs#4902)
0b6d54f 
* Fixed pnpm create-vite command documentation

pnpx is deprecated: https://pnpm.io/pnpx-cli

* Replaced other pnpx entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfin underfin underfin approved these changes

@patak-dev patak-dev patak-dev left review comments

@Shinigami92 Shinigami92 Shinigami92 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tropicalraisel @patak-dev @Shinigami92 @underfin